vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757838707
##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
contents {
from bootJar
- from war
Review comment:
... actually it still does something (even creates the SHA512 file). The
command is:
```
./gradlew -Pfineract.release clean build binaryDistTar
```
My plan was to replace that stitched together process with
https://jreleaser.org/ ... less moving parts, proper Gradle plugin.
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java
##########
@@ -45,6 +48,12 @@
private static final String LOAN_PRODUCT_SHORT_NAME =
"loanProductShortName";
private static final String SAVINGS_PRODUCT_SHORT_NAME =
"savingsProductShortName";
private static final String SHARE_PRODUCT_SHORT_NAME =
"sharesProductShortName";
+ private final ConfigurationReadPlatformService
configurationReadPlatformService;
+
+ @Autowired
+ public AccountNumberGenerator(final ConfigurationReadPlatformService
configurationReadPlatformService) {
+ this.configurationReadPlatformService =
configurationReadPlatformService;
+ }
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
