ptuomola commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757834318



##########
File path: fineract-provider/build.gradle
##########
@@ -274,10 +252,50 @@ bootJar {
     classifier = ''
 }
 
-bootWar {
-    enabled = false
+jib {
+    from {
+        // image = 'azul/zulu-openjdk-alpine:17-jre' // once we get rid of 
OpenJPA we could reduce space significantly
+        image = 'azul/zulu-openjdk-alpine:17'
+    }
+
+    to {
+        image = 'fineract'
+        tags = [
+            "${releaseVersion}",
+            'latest'
+        ]
+    }
+
+    container {
+        creationTime = 'USE_CURRENT_TIMESTAMP'
+        jvmFlags = [
+            '-Duser.home=/data',
+            '-Xmx1G',
+            '-Xms1G',
+            '-XshowSettings:vm',
+            '-XX:+UseContainerSupport',
+            '-XX:+UseStringDeduplication',
+            '-XX:MinRAMPercentage=25',
+            '-XX:MaxRAMPercentage=80'
+        ]
+        args = [
+            '-Dspring.profiles.active=basicauth',
+            '-Dfile.encoding=UTF-8',
+            '-Duser.timezone=UTC',

Review comment:
       Yes - I didn't mean changing the default if it's possible for us to 
override it for the integration tests. Unfortunately I think there's around 
20-30 tests that fail at different times of day (some before midnight, some 
after midnight etc) if the timezone is not set to Asia/Kalkuta

##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
         distributionBaseName = "apache-fineract-binary"
         contents {
             from bootJar
-            from war

Review comment:
       Sorry - I didn't mean we should distribute the WAR file - I don't think 
that's necessary. But when I tried to use distTar I could not get it to do 
anything at all - not even build a tar file with the bootJar in it. Does it 
work for you?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to