vidakovic commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-980826177


   ... not sure if my comment made it to GH... so here again:
   
   We can do that (environment variables to configure basic auth vs. oauth)... 
could we just do this in another iteration/PR? Just to avoid piling up too many 
changes here. I'm working in parallel with @hiteshprajapati on a follow up PR 
that will take full advantage of your improvements (aka Java config). I promise 
that this will cover your request... the build time copy and paste of different 
application.properties files is anyway not a best practice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to