adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374523225
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/AccountTransfersApiResourceSwagger.java:
##########
@@ -39,13 +39,13 @@ static final class GetAccountTransfersFromOffice {
private GetAccountTransfersFromOffice() {}
@Schema(example = "1")
- public Integer id;
+ public Long id;
@Schema(example = "HO")
public String name;
@Schema(example = "HO")
public String nameDecorated;
@Schema(example = "1")
- public Integer externalId;
+ public Long externalId;
Review Comment:
This looks wrong to me...It should be **String** based on the
OfficeData.java line 37 (it is ExternalId type, but we use the String value in
the fineract-client)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
