adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374639863
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java:
##########
@@ -64,7 +64,7 @@ static final class GetChargesAppliesToResponse {
private GetChargesAppliesToResponse() {}
@Schema(example = "1")
- public Long id;
+ public Integer id;
Review Comment:
This looks wrong to me...It should be Long based on the EnumOptionData
line:36
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java:
##########
@@ -76,7 +76,7 @@ static final class GetChargesCalculationTypeResponse {
private GetChargesCalculationTypeResponse() {}
@Schema(example = "1")
- public Long id;
+ public Integer id;
Review Comment:
This looks wrong to me...It should be Long based on the EnumOptionData
line:36
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java:
##########
@@ -88,7 +88,7 @@ static final class GetChargesPaymentModeResponse {
private GetChargesPaymentModeResponse() {}
@Schema(example = "1")
- public Long id;
+ public Integer id;
Review Comment:
This looks wrong to me...It should be Long based on the EnumOptionData
line:36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
