adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374639035


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/StandingInstructionApiResourceSwagger.java:
##########
@@ -47,7 +47,7 @@ private GetFromOfficeResponseStandingInstructionSwagger() {}
             @Schema(example = "Head Office")
             public String decoratedName;
             @Schema(example = "1")
-            public Integer externalId;
+            public Long externalId;

Review Comment:
   THis looks wrong to me based on OfficeData line 37. It should be String.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to