adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374637621
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/AccountTransfersApiResourceSwagger.java:
##########
@@ -529,17 +529,17 @@ public static final class
PostAccountTransfersRefundByTransferRequest {
private PostAccountTransfersRefundByTransferRequest() {}
@Schema(example = "2")
- public Integer fromAccountId;
+ public Long fromAccountId;
@Schema(example = "1")
- public Integer fromAccountType;
+ public Long fromAccountType;
@Schema(example = "1")
- public Integer toOfficeId;
+ public Long toOfficeId;
@Schema(example = "1")
- public Integer toClientId;
+ public Long toClientId;
@Schema(example = "2")
- public Integer toAccountType;
Review Comment:
This looks wrong to me based on AccountTransfersWritePlatformServiceImpl
line 105. It is the ordinal of an enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
