adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1559251985


##########
fineract-provider/src/test/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStepTest.java:
##########
@@ -175,4 +184,27 @@ public void 
givenLoanWithInstallmentOverdueAfterConfiguredDaysInLoanProductWhenS
         assertEquals(repaymentInstallment, loanPayloadForEvent);
         assertEquals(processedLoan, loanForProcessing);
     }
+
+    @Test
+    public void 
givenNonDisbursedLoanWhenStepExecutionThenNoBusinessEventIsRaised() {

Review Comment:
   I am not fully understand this test case, but please be sure to cover the 
following:
   GIVEN Loan is SUBMITTED or APPROVED and outstanding amount is greater than 
ZERO and one of the instalment is OVERDUE
   WHEN job got executed
   THEN no overdue event
   
   GIVEN Loan is ACTIVE, outstanding amount is ZERO, one of the installment is 
due date is matching with the actual date
   WHEN job got executed
   THEN no overdue event triggered



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to