adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1560626571
##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java:
##########
@@ -71,4 +77,12 @@ public String getEnumStyledName() {
public String getHumanReadableName() {
return "Check loan repayment overdue";
}
+
+ private static boolean isOverDueEventNeededToBeSent(Loan loan, Long
numberOfDaysBeforeDueDateToRaiseEvent, LocalDate currentDate,
Review Comment:
I dont see anywhere the loan status check... and the total outstanding check
was also not moved.
I didnt say **remove** them, i said move those checks to be the very first
conditions of this business step!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
