adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1562420558
##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java:
##########
@@ -71,4 +79,12 @@ public String getEnumStyledName() {
public String getHumanReadableName() {
return "Check loan repayment overdue";
}
+
+ private static boolean isOverDueEventNeededToBeSent(Loan loan, Long
numberOfDaysBeforeDueDateToRaiseEvent, LocalDate currentDate,
+ LoanRepaymentScheduleInstallment repaymentScheduleInstallment,
LocalDate repaymentDate) {
+ return
repaymentDate.plusDays(numberOfDaysBeforeDueDateToRaiseEvent).equals(currentDate)
+ &&
loan.getLoanSummary().getTotalOutstanding().compareTo(BigDecimal.ZERO) > 0
Review Comment:
Would you mind to move the
`loan.getLoanSummary().getTotalOutstanding().compareTo(BigDecimal.ZERO) > 0`
check to the top, next to the loan status check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
