alberto-art3ch commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1560068715
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/investor/externalassetowner/InitiateExternalAssetOwnerTransferTest.java:
##########
@@ -933,6 +936,35 @@ public void saleExceptionHandling() {
}
}
+ @Test
+ public void buybackOnATobeDeclinedPendingSale() {
Review Comment:
Done! Test case removed from this class
##########
fineract-provider/src/test/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStepTest.java:
##########
@@ -175,4 +184,27 @@ public void
givenLoanWithInstallmentOverdueAfterConfiguredDaysInLoanProductWhenS
assertEquals(repaymentInstallment, loanPayloadForEvent);
assertEquals(processedLoan, loanForProcessing);
}
+
+ @Test
+ public void
givenNonDisbursedLoanWhenStepExecutionThenNoBusinessEventIsRaised() {
Review Comment:
Done! Test cases created:
`givenActiveLoanWithZeroOutstandingWhenStepExecutionThenNoBusinessEventIsRaised`
`givenActiveLoanWithNonZeroOutstandingWhenStepExecutionThenBusinessEventIsRaised`
##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java:
##########
@@ -71,4 +77,12 @@ public String getEnumStyledName() {
public String getHumanReadableName() {
return "Check loan repayment overdue";
}
+
+ private static boolean isOverDueEventNeededToBeSent(Loan loan, Long
numberOfDaysBeforeDueDateToRaiseEvent, LocalDate currentDate,
Review Comment:
Done! removed the Loan status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
