Zeyad2003 commented on code in PR #3915:
URL: https://github.com/apache/fineract/pull/3915#discussion_r1665341397
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java:
##########
@@ -138,9 +138,6 @@ protected void doFilterInternal(HttpServletRequest request,
HttpServletResponse
}
if (!FIRST_REQUEST_PROCESSED) {
- final String baseUrl =
request.getRequestURL().toString().replace(request.getPathInfo(), "/");
Review Comment:
I replaced it with that
[line](https://github.com/apache/fineract/pull/3915/files#diff-7f872659757b85d5fcd50938abc4f805e15499f5e22026161dff8740fa4c4433R22).
The change is related to backward compatibility and should be covered by the
configuration.
I didn't fully understand all the reasons, I think it also relates to
changing the domain name.
@vidakovic told me to leave it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
