Zeyad2003 commented on code in PR #3915:
URL: https://github.com/apache/fineract/pull/3915#discussion_r1666487715
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java:
##########
@@ -138,9 +138,6 @@ protected void doFilterInternal(HttpServletRequest request,
HttpServletResponse
}
if (!FIRST_REQUEST_PROCESSED) {
- final String baseUrl =
request.getRequestURL().toString().replace(request.getPathInfo(), "/");
Review Comment:
> Adding only one place will not be enought. If someone is not using your
custom module, they are loosing the baseUrl settings...
I couldn't understand the full logic of any of them yet.
but, if we need to configure the URL inside the `application-v3.properties`
file when using the custom module, and the other settings when not using it,
then could the following implementation solve the problem?
- application-v3.properties line
``` properties
configuredBaseUrl=https://localhost:8443${FINERACT_SERVER_SERVLET_CONTEXT_PATH:/fineract-provider}
```
- add the following implementation to the condition block in
`TenantAwareBasicAuthenticationFilter`:
``` java
String configuredBaseUrl = System.getProperty("configuredBaseUrl");
if (configuredBaseUrl != null && !configuredBaseUrl.isEmpty()) {
baseUrl = configuredBaseUrl;
}
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
