oleksii-novikov-onix commented on code in PR #4475:
URL: https://github.com/apache/fineract/pull/4475#discussion_r2001939983
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -227,12 +230,14 @@ public class Loan extends
AbstractAuditableWithUTCDateTimeCustom<Long> {
private Integer termFrequency;
@Setter()
+ @Enumerated(EnumType.ORDINAL)
@Column(name = "term_period_frequency_enum", nullable = false)
- private Integer termPeriodFrequencyType;
+ private PeriodFrequencyType termPeriodFrequencyType;
Review Comment:
1. I see converters for LoanStatus, LoanSubStatus, and LoanTransactionType,
there doesn't appear to be a converter implementation for PeriodFrequencyType.
Do we need to implement a converter for PeriodFrequencyType?
2. Honestly, I don’t understand why we need a converters for LoanStatus,
LoanSubStatus etc. I thought that @Enumerated would do the same job as the
declared converters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
