Cocoa-Puffs commented on code in PR #4475:
URL: https://github.com/apache/fineract/pull/4475#discussion_r2003269425
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -227,12 +230,14 @@ public class Loan extends
AbstractAuditableWithUTCDateTimeCustom<Long> {
private Integer termFrequency;
@Setter()
+ @Enumerated(EnumType.ORDINAL)
@Column(name = "term_period_frequency_enum", nullable = false)
- private Integer termPeriodFrequencyType;
+ private PeriodFrequencyType termPeriodFrequencyType;
@Setter(AccessLevel.PACKAGE)
+ @Enumerated(EnumType.ORDINAL)
Review Comment:
I can remove it from enums where I ended up using a converter, I agree that
they can be confusing. The converters take precedence though, so in these cases
it's still the integer values that are saved, not the ordinal values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
