Cocoa-Puffs commented on code in PR #4475: URL: https://github.com/apache/fineract/pull/4475#discussion_r2002764363
########## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanStatusConverter.java: ########## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.loanaccount.domain; + +import jakarta.persistence.AttributeConverter; +import jakarta.persistence.Converter; + +@Converter(autoApply = true) +public class LoanStatusConverter implements AttributeConverter<LoanStatus, Integer> { + + @Override + public Integer convertToDatabaseColumn(LoanStatus attribute) { + return attribute == null ? null : attribute.getValue(); + } + + @Override + public LoanStatus convertToEntityAttribute(Integer dbData) { + return dbData == null ? LoanStatus.INVALID : LoanStatus.fromInt(dbData); Review Comment: loan_status_id is currently non nullable on the database side so I don't think we can ever get a null there. Moreover this was the previous behaviour. If you look at getStatus in Loan.java, it just returns LoanStatus.fromInt, which returns INVALID on null values. I can change the converter to simply call the fromInt as that would be essentially the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
