Cocoa-Puffs commented on code in PR #4475:
URL: https://github.com/apache/fineract/pull/4475#discussion_r2002749197
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -227,12 +230,14 @@ public class Loan extends
AbstractAuditableWithUTCDateTimeCustom<Long> {
private Integer termFrequency;
@Setter()
+ @Enumerated(EnumType.ORDINAL)
@Column(name = "term_period_frequency_enum", nullable = false)
- private Integer termPeriodFrequencyType;
+ private PeriodFrequencyType termPeriodFrequencyType;
Review Comment:
I written converters for enums that have integer values that differ from
their ordinal values. These values were what we saved to the database
previously and I didn't want to introduce new behaviour or change the data
being saved. PeriodFrequencyTypes integer values correspond to the ordinal
values of enums so it didn't need a converter. (LoanTransactionType is almost
good, it's just missing number 11).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
