adamsaghy commented on code in PR #4623:
URL: https://github.com/apache/fineract/pull/4623#discussion_r2123024660
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java:
##########
@@ -126,13 +126,15 @@ public CommandProcessingResult create(final JsonCommand
command) {
final SavingsTransactionBooleanValues transactionBooleanValues =
new SavingsTransactionBooleanValues(isAccountTransfer,
isRegularTransaction,
fromSavingsAccount.isWithdrawalFeeApplicableForTransfer(), isInterestTransfer,
isWithdrawBalance);
final SavingsAccountTransaction withdrawal =
this.savingsAccountDomainService.handleWithdrawal(fromSavingsAccount, fmt,
- transactionDate, transactionAmount, paymentDetail,
transactionBooleanValues, backdatedTxnsAllowedTill);
+ transactionDate, transactionAmount, paymentDetail,
transactionBooleanValues, backdatedTxnsAllowedTill,
Review Comment:
We should check whether enable-auto-generated-external-id is true or false...
if it is true, we need to generate automatically external id.
Example:
```
if (externalId.isEmpty() &&
TemporaryConfigurationServiceContainer.isExternalIdAutoGenerationEnabled()) {
externalId = ExternalId.generate();
}
```
org.apache.fineract.portfolio.loanaccount.service.LoanAssemblerImpl#updateFrom,
line 537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
