adamsaghy commented on code in PR #4623:
URL: https://github.com/apache/fineract/pull/4623#discussion_r2123030869
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -171,7 +171,7 @@ public CommandProcessingResult activateFDAccount(final Long
savingsId, final Jso
if (portfolioAccountData == null) {
final PaymentDetail paymentDetail = null;
this.depositAccountDomainService.handleFDDeposit(account,
fmt, account.getActivationDate(),
- amountForDeposit.getAmount(), paymentDetail);
+ amountForDeposit.getAmount(), paymentDetail,
ExternalId.empty());
Review Comment:
We should check whether enable-auto-generated-external-id is true or false...
if it is true, we need to generate automatically external id.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -244,7 +245,7 @@ public void processPostActiveActions(final SavingsAccount
account, final DateTim
if (amountForDeposit.isGreaterThanZero()) {
boolean isAccountTransfer = false;
this.savingsAccountDomainService.handleDeposit(account, fmt,
account.getActivationDate(), amountForDeposit.getAmount(), null,
- isAccountTransfer, isRegularTransaction, false);
+ isAccountTransfer, isRegularTransaction, false,
ExternalId.empty());
Review Comment:
We should check whether enable-auto-generated-external-id is true or false...
if it is true, we need to generate automatically external id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
