adamsaghy commented on code in PR #4623:
URL: https://github.com/apache/fineract/pull/4623#discussion_r2123033217


##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -549,10 +549,10 @@ public void postInterest(final MathContext mc, final 
LocalDate interestPostingUp
                     if 
(interestEarnedToBePostedForPeriod.isGreaterThanOrEqualTo(Money.zero(currency)))
 {
 
                         newPostingTransaction = 
SavingsAccountTransaction.interestPosting(this, office(), 
interestPostingTransactionDate,
-                                interestEarnedToBePostedForPeriod, 
interestPostingPeriod.isUserPosting());
+                                interestEarnedToBePostedForPeriod, 
interestPostingPeriod.isUserPosting(), ExternalId.empty());

Review Comment:
   We should check whether enable-auto-generated-external-id is true or false...
   
   if it is true, we need to generate automatically external id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to