adamsaghy commented on code in PR #4623:
URL: https://github.com/apache/fineract/pull/4623#discussion_r2123029979
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/FixedDepositAccount.java:
##########
@@ -197,7 +197,7 @@ public void
updateMaturityDateAndAmountBeforeAccountActivation(final MathContext
String refNo = null;
final Money transactionAmountMoney = Money.of(getCurrency(),
this.accountTermAndPreClosure.depositAmount());
final SavingsAccountTransaction transaction =
SavingsAccountTransaction.deposit(null, office(), null,
- this.accountSubmittedOrActivationDate(),
transactionAmountMoney, refNo);
+ this.accountSubmittedOrActivationDate(),
transactionAmountMoney, refNo, ExternalId.empty());
Review Comment:
We should check whether enable-auto-generated-external-id is true or false...
if it is true, we need to generate automatically external id.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/RecurringDepositAccount.java:
##########
@@ -394,7 +394,7 @@ private List<SavingsAccountTransaction>
getTransactions(final LocalDate depositE
dueDate = latestTransactionDate;
}
final SavingsAccountTransaction transaction =
SavingsAccountTransaction.deposit(null, office(), null, dueDate,
-
installment.getDepositAmountOutstanding(getCurrency()), refNo);
+
installment.getDepositAmountOutstanding(getCurrency()), refNo,
ExternalId.empty());
Review Comment:
We should check whether enable-auto-generated-external-id is true or false...
if it is true, we need to generate automatically external id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
