adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155193121
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/SavingsAccountTransactionType.java:
##########
@@ -93,9 +93,33 @@ public boolean isDebitEntryType() {
return entryType != null && entryType.isDebit();
}
- public static SavingsAccountTransactionType fromInt(final Integer value) {
- SavingsAccountTransactionType transactionType = BY_ID.get(value);
- return transactionType == null ? INVALID : transactionType;
+ public static SavingsAccountTransactionType fromInt(final Integer
transactionType) {
Review Comment:
Why is this better than original?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
