adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155193530


##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/SavingsAccountTransactionType.java:
##########
@@ -114,6 +138,10 @@ public boolean isInterestPosting() {
         return this == INTEREST_POSTING;
     }
 
+    public boolean isAccrual() {

Review Comment:
   why to change this?



##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/SavingsApiConstants.java:
##########
@@ -35,6 +35,7 @@ public class SavingsApiConstants {
     public static final String withdrawnByApplicantAction = 
".withdrawnByApplicant";
     public static final String activateAction = ".activate";
     public static final String modifyApplicationAction = ".modify";
+    public static final String undoActivateAction = ".undoactivate";

Review Comment:
   Unrelated change... please raise separate PR!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to