adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155197612
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -285,17 +291,28 @@ public static SavingsAccountTransactionData
interestPosting(final SavingsAccount
SavingsAccountTransactionEnumData transactionType = new
SavingsAccountTransactionEnumData(
savingsAccountTransactionType.getValue().longValue(),
savingsAccountTransactionType.getCode(),
savingsAccountTransactionType.getValue().toString());
- return createImport(transactionType, savingsAccount.getId(), date,
amount.getAmount(), submittedOnDate, isManualTransaction);
+ return createImport(transactionType, savingsAccount.getId(), date,
amount.getAmount(), submittedOnDate, isManualTransaction, false);
+ }
+
+ public static SavingsAccountTransactionData accrual(final
SavingsAccountData savingsAccount, final LocalDate date, final Money amount,
Review Comment:
It would be better to use a mapper for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
