adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155201378
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionEnumData.java:
##########
@@ -70,11 +70,11 @@ public SavingsAccountTransactionEnumData(final Long id,
final String code, final
this.rejectTransfer = transactionType ==
SavingsAccountTransactionType.REJECT_TRANSFER;
this.writtenoff = transactionType ==
SavingsAccountTransactionType.WRITTEN_OFF;
this.overdraftFee = false;
- this.overdraftInterest = transactionType ==
SavingsAccountTransactionType.OVERDRAFT_INTEREST;
- this.withholdTax = transactionType ==
SavingsAccountTransactionType.WITHHOLD_TAX;
- this.escheat = transactionType ==
SavingsAccountTransactionType.ESCHEAT;
- this.amountHold = transactionType ==
SavingsAccountTransactionType.AMOUNT_HOLD;
- this.amountRelease = transactionType ==
SavingsAccountTransactionType.AMOUNT_RELEASE;
+ this.overdraftInterest =
Long.valueOf(SavingsAccountTransactionType.OVERDRAFT_INTEREST.getValue()).equals(this.id);
Review Comment:
Original was better...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
