adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155204747
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsProductData.java:
##########
@@ -594,7 +603,7 @@ public boolean isCashBasedAccountingEnabled() {
}
public boolean isAccrualBasedAccountingEnabled() {
- return isUpfrontAccrualAccounting() || isPeriodicAccrualAccounting();
+ return isUpfrontAccrualAccounting() && isPeriodicAccrualAccounting();
Review Comment:
This seems wrong!
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/domain/interest/AnnualCompoundingPeriod.java:
##########
@@ -47,7 +47,7 @@ public static AnnualCompoundingPeriod create(final
LocalDateInterval periodInter
public BigDecimal calculateInterest(final
SavingsCompoundingInterestPeriodType compoundingInterestPeriodType,
final SavingsInterestCalculationType interestCalculationType,
final BigDecimal interestToCompound,
final BigDecimal interestRateAsFraction, final long daysInYear,
final BigDecimal minBalanceForInterestCalculation,
- final BigDecimal overdraftInterestRateAsFraction, final BigDecimal
minOverdraftForInterestCalculation) {
+ final BigDecimal overdraftInterestRateAsFraction, final BigDecimal
minOverdraftForInterestCalculation, Boolean isAcraul) {
Review Comment:
typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
