adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155204107
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsProductData.java:
##########
@@ -345,16 +351,17 @@ public static SavingsProductData lookup(final Long id,
final String name) {
penaltyOptions, feeToIncomeAccountMappings,
penaltyToIncomeAccountMappings, allowOverdraft, overdraftLimit,
minRequiredBalance, enforceMinRequiredBalance,
maxAllowedLienLimit, lienAllowed, minBalanceForInterestCalculation,
nominalAnnualInterestRateOverdraft,
minOverdraftForInterestCalculation, withHoldTax, taxGroup, taxGroupOptions,
- isDormancyTrackingActive, daysToInactive, daysToDormancy,
daysToEscheat, accountMappingForPayment);
+ isDormancyTrackingActive, daysToInactive, daysToDormancy,
daysToEscheat, accountMappingForPayment, accrualCharges);
}
- public static SavingsProductData createForInterestPosting(final Long id,
final EnumOptionData accountingRule) {
- return new SavingsProductData(id, accountingRule);
+ public static SavingsProductData createForInterestPosting(final Long id,
final String productName,
+ final EnumOptionData accountingRule) {
+ return new SavingsProductData(id, productName, accountingRule);
}
- private SavingsProductData(final Long id, final EnumOptionData
accountingRule) {
+ private SavingsProductData(final Long id, final String productName, final
EnumOptionData accountingRule) {
this.id = id;
- this.name = null;
+ this.name = productName;
Review Comment:
why do we need product name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
