gyfora commented on a change in pull request #120:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/120#discussion_r836237750
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -172,10 +174,14 @@ public boolean isJobManagerPortReady(Configuration
config) {
clusterClient.cancel(jobID).get(1, TimeUnit.MINUTES);
break;
case SAVEPOINT:
+ final String savepointDirectory =
+ Preconditions.checkNotNull(
+
conf.get(CheckpointingOptions.SAVEPOINT_DIRECTORY));
+ final long timeout =
operatorConfiguration.getFlinkClientTimeout().getSeconds();
Review comment:
The flink client timeout that we have in the operator config is mostly
calibrated for listing actions and has 10 sec default. I think that might cause
problems here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
