wangyang0918 commented on a change in pull request #120:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/120#discussion_r836256409
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -172,10 +174,14 @@ public boolean isJobManagerPortReady(Configuration
config) {
clusterClient.cancel(jobID).get(1, TimeUnit.MINUTES);
break;
case SAVEPOINT:
+ final String savepointDirectory =
+ Preconditions.checkNotNull(
+
conf.get(CheckpointingOptions.SAVEPOINT_DIRECTORY));
+ final long timeout =
operatorConfiguration.getFlinkClientTimeout().getSeconds();
Review comment:
> It should somehow be configurable I agree on that otherwise this will
fail for larger states :/
I am not sure about this comment. Actually, I do not find a config options
for checkpoint timeout. It seems it could only be configured via
`env.getCheckpointConfig().setCheckpointTimeout(60000)`. If we want to to get
the configured timeout, we might need to access the running job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
