wangyang0918 commented on a change in pull request #120:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/120#discussion_r836246896
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -172,10 +174,14 @@ public boolean isJobManagerPortReady(Configuration
config) {
clusterClient.cancel(jobID).get(1, TimeUnit.MINUTES);
break;
case SAVEPOINT:
+ final String savepointDirectory =
+ Preconditions.checkNotNull(
+
conf.get(CheckpointingOptions.SAVEPOINT_DIRECTORY));
+ final long timeout =
operatorConfiguration.getFlinkClientTimeout().getSeconds();
Review comment:
I am afraid we could not get it from the flink config and it could also
be overridden by user.
```
env.getCheckpointConfig().setCheckpointTimeout(60000);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
