gyfora commented on a change in pull request #120:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/120#discussion_r836243310
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -172,10 +174,14 @@ public boolean isJobManagerPortReady(Configuration
config) {
clusterClient.cancel(jobID).get(1, TimeUnit.MINUTES);
break;
case SAVEPOINT:
+ final String savepointDirectory =
+ Preconditions.checkNotNull(
+
conf.get(CheckpointingOptions.SAVEPOINT_DIRECTORY));
+ final long timeout =
operatorConfiguration.getFlinkClientTimeout().getSeconds();
Review comment:
How about taking the checkpoint timeout from the flink config directly
here? (And use the default for that from flink)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
