ayushi-agarwal commented on code in PR #5398:
URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1566744350
##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -319,6 +319,15 @@ message WindowRel {
}
}
+message WindowGroupLimitRel {
Review Comment:
@JkSelf For now we are only supporting row number but later when we support
rank and dense rank, then I was thinking that we would need an extra parameter
for passing the function name, so I created the new operator. Shall that info
also be passed in advanced_extension?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
