JkSelf commented on code in PR #5398:
URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1570319408
##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -319,6 +319,15 @@ message WindowRel {
}
}
+message WindowGroupLimitRel {
Review Comment:
@ayushi-agarwal Yes, it can be included in the advanced_extension. However,
it appears that the WindowGroupLimitRel is intended to map to the TopNRowNumber
operator, not the Window operator. Therefore, it make sense to introduce a new
operator in Substrait for this purpose. @zhztheplayer Do you have any input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
