zhztheplayer commented on code in PR #5398:
URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1571875031
##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -319,6 +319,15 @@ message WindowRel {
}
}
+message WindowGroupLimitRel {
Review Comment:
To make things fancier, we can even add a `TopNRowNumberExec` in
`backends-velox` module then use a rule to convert Spark's
`WindowGroupLimitExec` conditionally to `TopNRowNumberExec`. That would be the
best method to solve this kind of operator-mapping problems.
However if you think `WindowGroupLimitExec` and `TopNRowNumberRel` doesn't
have much semantic difference apart of the window function types they support,
then we can do it without rules and it's also fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
