zhztheplayer commented on code in PR #5398:
URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1571868820
##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -319,6 +319,15 @@ message WindowRel {
}
}
+message WindowGroupLimitRel {
Review Comment:
> Therefore, it make sense to introduce a new operator in Substrait for this
purpose.
I am inclined to this approach, like adding a `TopNRowNumberRel` or
something in proto. 1:1 mapping from Velox's operator to Substrait / Gluten
operator is definitely encouraged, like discussed in
https://github.com/apache/incubator-gluten/pull/5409#discussion_r1566884037.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
