zhztheplayer commented on code in PR #5447:
URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578928045
##########
gluten-core/src/main/scala/org/apache/gluten/utils/PlanUtil.scala:
##########
@@ -70,6 +70,9 @@ object PlanUtil {
case _: InputAdapter => false
case _: WholeStageCodegenExec => false
case r: ReusedExchangeExec => isVanillaColumnarOp(r.child)
+ case f: FileSourceScanExec =>
+
!f.relation.fileFormat.getClass.getSimpleName.equals("ArrowCSVFileFormat") &&
+ f.supportsColumnar
Review Comment:
So what if we add a rule to convert `FileSourceScanExec` to
`ArrowFileSourceScanExec` that outputs Arrow columnar data by default? Which is
reasonable since Gluten is guaranteed compatible with Arrow at arch level. The
code can be placed in `gluten-data` and `cpp/core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
