zhztheplayer commented on code in PR #5447:
URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578936542
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -748,6 +749,14 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
SparkShimLoader.getSparkShims.getExtendedColumnarPostRules() ::: List()
}
+ override def genInjectPostHocResolutionRules(): List[SparkSession =>
Rule[LogicalPlan]] = {
+ val buf: ListBuffer[SparkSession => Rule[LogicalPlan]] = ListBuffer()
+ if (BackendsApiManager.getSettings.enableNativeArrowReadFiles()) {
+ buf += ArrowConvertorRule
Review Comment:
Would you like to explain a bit about the reason to inject the rule as
PostHocResolutionRule? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
