ulysses-you commented on code in PR #5447:
URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1580752830
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformSingleNode.scala:
##########
@@ -303,7 +303,15 @@ object TransformOthers {
class ReplaceSingleNode() extends LogLevelUtil with Logging {
def doReplace(p: SparkPlan): SparkPlan = {
- val plan = p
+ val plan = p match {
+ case plan: FileSourceScanExec
+ if plan.relation.fileFormat.getClass.getSimpleName ==
"ArrowCSVFileFormat" =>
+ val arrowScan = ArrowFileSourceScanExec(plan)
+ TransformHints.tagNotTransformable(arrowScan, "Arrow scan cannot
transform")
+ return arrowScan
+ case p => p
+ }
+
if (TransformHints.isNotTransformable(plan)) {
Review Comment:
shall we handle `ArrowFileSourceScanExec` inside this branch ?
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformSingleNode.scala:
##########
@@ -322,6 +330,8 @@ object TransformOthers {
applyScanTransformer(plan)
case plan: FileSourceScanExec =>
applyScanTransformer(plan)
+ case plan: ArrowFileSourceScanExec =>
+ applyScanTransformer(plan)
Review Comment:
it seems we can never reach here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
