zhztheplayer commented on code in PR #5447:
URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1579033915
##########
gluten-core/src/main/scala/org/apache/gluten/utils/PlanUtil.scala:
##########
@@ -70,6 +70,9 @@ object PlanUtil {
case _: InputAdapter => false
case _: WholeStageCodegenExec => false
case r: ReusedExchangeExec => isVanillaColumnarOp(r.child)
+ case f: FileSourceScanExec =>
+
!f.relation.fileFormat.getClass.getSimpleName.equals("ArrowCSVFileFormat") &&
+ f.supportsColumnar
Review Comment:
We can simply add a validation line to
https://github.com/apache/incubator-gluten/blob/main/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala
And add some transformation code to
https://github.com/apache/incubator-gluten/blob/c4b4c72732f2d662c6c7b0b41c46d47f77b281d0/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformSingleNode.scala#L289
Could just follow the normal way we transform file scan to file scan
transformer.
It's awkward that we still need to take time to find a way to correctly
inject some rules after such long time of development of Gluten. We need some
complete refactors against the base arch eventually...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
