jkhaliqi commented on code in PR #8470:
URL: https://github.com/apache/incubator-gluten/pull/8470#discussion_r1907913715
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -195,9 +195,12 @@ std::shared_ptr<ColumnarBatch>
WholeStageResultIterator::next() {
if (task_->isFinished()) {
return nullptr;
}
- velox::RowVectorPtr vector;
+ velox::RowVectorPtr vector = nullptr;
while (true) {
auto future = velox::ContinueFuture::makeEmpty();
+ if (task == nullptr) {
Review Comment:
Use of Uninitialized
Variable@cpp/velox/compute/[WholeStageResultIterator.cc:212](http://wholestageresultiterator.cc:212/)
Use of Uninitialized
Variable@cpp/velox/compute/[WholeStageResultIterator.cc:209](http://wholestageresultiterator.cc:209/)
Assuming the task_ needed to be checked to make sure it was not nullptr in
order to be used for `task_->next(&future); `and `task_->taskId()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
