jkhaliqi commented on code in PR #8470:
URL: https://github.com/apache/incubator-gluten/pull/8470#discussion_r1907924485
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -215,7 +215,11 @@ class ArbitratorFactoryRegister {
};
VeloxMemoryManager::VeloxMemoryManager(const std::string& kind,
std::unique_ptr<AllocationListener> listener)
- : MemoryManager(kind), listener_(std::move(listener)) {
+ : MemoryManager(kind) {
+ if (listener == nullptr) {
Review Comment:
Yeah there was some CVE's for
[VeloxMemoryManager.cc:243](http://veloxmemorymanager.cc:243/)
Use of Uninitialized
Variable@cpp/velox/memory/[VeloxMemoryManager.cc:250](http://veloxmemorymanager.cc:250/)
Use of Uninitialized
Variable@cpp/velox/memory/[VeloxMemoryManager.cc:253](http://veloxmemorymanager.cc:253/)
which was around here so I figured it might be with the listener being
passed in as nullptr so figured I would check that before the method goes in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
