jkhaliqi commented on code in PR #8470:
URL: https://github.com/apache/incubator-gluten/pull/8470#discussion_r1911400677
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -192,10 +192,13 @@ std::shared_ptr<velox::core::QueryCtx>
WholeStageResultIterator::createNewVeloxQ
std::shared_ptr<ColumnarBatch> WholeStageResultIterator::next() {
tryAddSplitsToTask();
+ if (task_ == nullptr) {
+ return nullptr;
+ }
if (task_->isFinished()) {
return nullptr;
}
- velox::RowVectorPtr vector;
+ velox::RowVectorPtr vector = nullptr;
Review Comment:
`std::shared_ptr<connector::hive::HiveBucketProperty> bucketProperty =
nullptr;`
I see the above as well, but not sure if assignment should be removed. Will
not add in nullptr for share pointers in this PR for Uninitialized variables
though, should be updated as false positives
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
