jkhaliqi commented on code in PR #8470:
URL: https://github.com/apache/incubator-gluten/pull/8470#discussion_r1907932744
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -253,7 +257,10 @@ VeloxMemoryManager::VeloxMemoryManager(const std::string&
kind, std::unique_ptr<
namespace {
MemoryUsageStats collectVeloxMemoryUsageStats(const velox::memory::MemoryPool*
pool) {
- MemoryUsageStats stats;
+ if (pool == nullptr) {
Review Comment:
Use of Uninitialized
Variable@cpp/velox/memory/[VeloxMemoryManager.cc:255](http://veloxmemorymanager.cc:255/)
Use of Uninitialized
Variable@cpp/velox/memory/[VeloxMemoryManager.cc:256](http://veloxmemorymanager.cc:256/)
Use of Uninitialized
Variable@cpp/velox/memory/[VeloxMemoryManager.cc:257](http://veloxmemorymanager.cc:257/)
55 being the pool in the paramter I figured I would check if that is nullPtr
then stats being 56 I just added {}
and then 57 was using pool->usedBytes so the assuming the nullptr check
above should fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
