Yohahaha commented on PR #8684: URL: https://github.com/apache/incubator-gluten/pull/8684#issuecomment-2649784753
> > > Do we need to extend this function to allow all configures? > > > > > > yeah, we may need add new method `GlutenConfigUtil#get(ConfigEntry)` to process non-sql configs. > > Hey @Yohahaha We cannot use `ConfigEntry` since they are private in Spark package only > > https://github.com/apache/spark/blob/cea79dc1918b7f03870fe1cb189da9a152e3bbaf/core/src/main/scala/org/apache/spark/internal/config/package.scala#L1892-L1899 > > How about only extract a specific method that handle bytes value only to reduce duplicates? sounds good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
