jinchengchenghh commented on code in PR #8684:
URL: https://github.com/apache/incubator-gluten/pull/8684#discussion_r1959417143
##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -504,24 +502,20 @@ object GlutenConfig {
(
GLUTEN_COLUMNAR_TO_ROW_MEM_THRESHOLD.key,
GLUTEN_COLUMNAR_TO_ROW_MEM_THRESHOLD.defaultValue.get.toString),
- (
- SPARK_UNSAFE_SORTER_SPILL_READER_BUFFER_SIZE,
- SPARK_UNSAFE_SORTER_SPILL_READER_BUFFER_SIZE_DEFAULT.toString),
- (
- SPARK_SHUFFLE_SPILL_DISK_WRITE_BUFFER_SIZE,
- SPARK_SHUFFLE_SPILL_DISK_WRITE_BUFFER_SIZE_DEFAULT.toString),
(SPARK_SHUFFLE_SPILL_COMPRESS,
SPARK_SHUFFLE_SPILL_COMPRESS_DEFAULT.toString)
)
keyWithDefault.forEach(e => nativeConfMap.put(e._1, conf.getOrElse(e._1,
e._2)))
-
- conf
- .get(SPARK_SHUFFLE_FILE_BUFFER)
- .foreach(
- v =>
- nativeConfMap
- .put(
- SPARK_SHUFFLE_FILE_BUFFER,
- (JavaUtils.byteStringAs(v, ByteUnit.KiB) * 1024).toString))
+ GlutenConfigUtil.mapByteConfValue(
Review Comment:
Maybe we should add a new list like `keyWithDefault`, move the bytes config
together, it will be more easier for users to add byte config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
