jackylee-ch commented on PR #8684: URL: https://github.com/apache/incubator-gluten/pull/8684#issuecomment-2665123300
> Do we need to update it from `spark.gluten` to `spark.`? We may map other Spark config with Velox config. We could also keep this implementation because it may take effect for the Spark downstream project such as Iceberg config in the future. How about it? @Yohahaha The current code only gets the configuration of gluten, as `ConfigEntry` has been refactored. we need another method to handle the `ConfigEntry` of vanilla spark. BTW, fully scanning all spark conf will be time-consuming. Maybe we can add a spark config registration list so that only the registered conf will be passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
