jinchengchenghh commented on PR #8684: URL: https://github.com/apache/incubator-gluten/pull/8684#issuecomment-2665074966
> > https://github.com/apache/incubator-gluten/blob/e0092089453286b6822447a875666b41ab6f0b5c/shims/common/src/main/scala/org/apache/spark/sql/internal/GlutenConfigUtil.scala#L21-L45 > > > > `spark.unsafe.sorter.spill.reader.buffer.size=2m` should be converted by above codes, could you investigate why it not works? > > oh, GlutenConfigUtil only process the config which prefix is 'spark.gluten'. Do we need to update it from `spark.gluten` to `spark.`? We may map other Spark config with Velox config. We could also keep this implementation because it may take effect for the Spark downstream project such as Iceberg config in the future. How about it? @Yohahaha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
