Yifeng-Wang commented on code in PR #9107:
URL: https://github.com/apache/incubator-gluten/pull/9107#discussion_r2009998746
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -164,6 +164,32 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
child.map(replaceWithExpressionTransformer0(_, attributeSeq,
expressionsMap)),
i)
}
+ } else if (objectName.endsWith("CharVarcharCodegenUtils")) {
Review Comment:
@jinchengchenghh Hi Jincheng, I now extracted the StaticInvoke branch to a
new replaceStaticInvokeWithExpressionTransformer function.
Please take a look when you have time, and let me know if there are any
further improvements needed. I'm happy to make additional changes if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
