jinchengchenghh commented on code in PR #9107:
URL: https://github.com/apache/incubator-gluten/pull/9107#discussion_r2010620310
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -109,6 +109,66 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
}
}
+ private def replaceStaticInvokeWithExpressionTransformer(
+ i: StaticInvoke,
+ attributeSeq: Seq[Attribute],
+ expressionsMap: Map[Class[_], String]): ExpressionTransformer = {
+ val objectName = i.staticObject.getName.stripSuffix("$")
+
+ if (objectName.endsWith("UrlCodec")) {
Review Comment:
I think most of the cases we need all the argument, UrlCodec is a special
case, maybe because the backend only supports "UTF-8" , we should throw
exception if 2nd argument is not "UTF-8" but not.
So other common cases should use the `staticInvokeMap`, that can also help
developer figure out the special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
