Yifeng-Wang commented on code in PR #9107:
URL: https://github.com/apache/incubator-gluten/pull/9107#discussion_r2010595764
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -109,6 +109,66 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
}
}
+ private def replaceStaticInvokeWithExpressionTransformer(
+ i: StaticInvoke,
+ attributeSeq: Seq[Attribute],
+ expressionsMap: Map[Class[_], String]): ExpressionTransformer = {
+ val objectName = i.staticObject.getName.stripSuffix("$")
+
+ if (objectName.endsWith("UrlCodec")) {
Review Comment:
Hi @jinchengchenghh . Here I notice there's a diff between how "UrlCodec"
and "CharVarcharCodegenUtils" handles StaticInvoke's arguments.
Turns out that, "UrlCodec" only uses 1st arg `val child = i.arguments.head`
which is the column identifier but had the 2nd argument "UTF-8" ignored. while
`CharVarcharCodegenUtils` takes all the params (i.e. col identifier & length
limit) by `val children = i.arguments`.
So I'm a bit unsure how we could better handle such discrepancy here since
additional args handling logic would make it complex again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
